[Buildroot] svn commit: trunk/buildroot: package package/busybox project target/ etc...

Ulf Samuelsson ulf at atmel.com
Thu Jul 12 13:56:50 UTC 2007


tor 2007-07-12 klockan 16:42 +0200 skrev Bernhard Fischer:
> On Thu, Jul 12, 2007 at 06:11:06AM -0700, ulf at uclibc.org wrote:
> >Author: ulf
> >Date: 2007-07-12 06:11:03 -0700 (Thu, 12 Jul 2007)
> >New Revision: 19070
> 
> >Modified: trunk/buildroot/Makefile
> >===================================================================
> >--- trunk/buildroot/Makefile	2007-07-12 00:59:00 UTC (rev 19069)
> >+++ trunk/buildroot/Makefile	2007-07-12 13:11:03 UTC (rev 19070)
> >@@ -155,6 +155,12 @@
> > else
> > TARGETS:=uclibc
> > endif
> >+
> >+PROJECT:=$(strip $(subst ",, $(BR2_PROJECT)))
> >+HOSTNAME:=$(strip $(subst ",, $(BR2_HOSTNAME)))
> >+BANNER:=$(strip $(subst ",, $(BR2_BANNER)))
> 
> This breaks vi's syntax highlighing, please fix

Pls supply a template on what you want me to do.

"vi" on OpenSuSE is not compiled with that extension
so I can't test that.
On gedit there 
This is how it is done in other places in buildroot.



> Also, you're aware that HOSTNAME previously was set to the hostname of
> the build host and you just broke this, aren't you?
> 
OK, I'll change to TARGET_HOSTNAME


> >Added: trunk/buildroot/project/Config.in
> >===================================================================
> >--- trunk/buildroot/project/Config.in	                        (rev 0)
> >+++ trunk/buildroot/project/Config.in	2007-07-12 13:11:03 UTC (rev 19070)
> >@@ -0,0 +1,26 @@
> >+menu "Project Options"
> >+
> >+config BR2_PROJECT
> >+	string "Project name"
> >+	default "uclibc"
> >+	help
> >+	  The project name is used to define subdirectories
> >+	  * where the Board Support Packages are built
> >+	    (Linux,Root fs Bootmonitor,Utilities etc.)
> 
> whitespace dammaged CSVs

Is it the indentation you don't like? Pls elaborate.

> 
> Please add inline documentation to PROJECT_BUILD_DIR and BUILD_DIR

/Done, pls check if this is what you meant.

> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot




More information about the buildroot mailing list