[Buildroot] x11r7 created $(BUILD_DIR)/<package-dir>/.stamp_downloaded

Ulf Samuelsson ulf at atmel.com
Tue Aug 14 18:30:07 UTC 2007


tis 2007-08-14 klockan 16:20 +0200 skrev Benjamin Tietz:
> On Sat, Aug 11, 2007 at 10:29:31PM +0200, Ulf Samuelsson wrote:
> > The Makefile seems to create this file to indicate that it 
> > had downloaded the source code.
> > The $(BUILD_DIR) becomes really crowded this way.
> From this one file, I see.
> > 

Every package downloaded by make source, 
creates a directory in $(BUILD_DIR)
- And just to have a storage location for the
"<PACKAGE>/.stamp_downloaded".


> > I Think we should modify this so that the Makefile
> > checks for the existance of the source file in $(DL_DIR)
> > like most other packages.
> > Tried, (see patch below), but the rule:
> > 
> > +$(DL_DIR)/$$($(PKG)_SOURCE):
> >         $(call MESSAGE,"Downloading")
> >         test -e $(DL_DIR)/$($(PKG)_SOURCE) || $(WGET) -P $(DL_DIR)
> > $($(PKG)_SITE)/$($(PKG)_SOURCE)
> >         mkdir -p $(@D)
> Mainly because of the way, make handles variables. They get
> expanded,when the makefile is parsed. Even the doubled dollarsign can't
> help you here.
> 
> > 
> > fails (is not found) so I had to add 
> > 
> > +$$($(2)_TARGET_SOURCE):
> > +       $(WGET) -P $(DL_DIR) $$($(2)_SITE)/$$($(2)_SOURCE)
> > +
> > 
> In the macro it gets evaluated every time any package wants it to use.
> Does that really pays the one unneeded stamp-file?
> 

No 50-100 new directories in $(BUILD_DIR) 
(I didn't count)

> > to make it work.
> > Anyone got a clue why the first rule fails?
> > 
> > 
> > Maybe we should also consider building x11r7 in $(BUILD_DIR)/x11r7
> > due to crowding.
> You even get afraid of crowding, aren't you?
> > 

NO, pissed off...
I like all/most of the folders to fit into one window w/o scrolling.

BR
Ulf Samuelsson






More information about the buildroot mailing list